-
Notifications
You must be signed in to change notification settings - Fork 75
Farrah Rios && Auredy Sanchez #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rios-isabelle-farrah
wants to merge
6
commits into
joinpursuit:main
Choose a base branch
from
rios-isabelle-farrah:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
312a44e
add exclamation mark
coreyladovsky e6257a1
add exclamation mark
auredysanchez 57fd031
initial commit
rios-isabelle-farrah 1019948
trying to merge
auredysanchez 255839f
commit file
auredysanchez 516d967
solve all problems
rios-isabelle-farrah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,68 @@ | ||
| const rls = require('readline-sync') | ||
| const rls = require("readline-sync"); | ||
|
|
||
| /** | ||
| * Starts the game by prompting the user if they want to play | ||
| * Calls either gameLoop() or quitGame() | ||
| * | ||
| * | ||
| * @returns {undefined} | ||
| */ | ||
| const startGame = () => { | ||
|
|
||
|
|
||
| const gameLoop = () =>{ | ||
| console.log("Let's start!") | ||
| console.log("I have a random number in mind") | ||
| console.log("It's between 1 and 1000") | ||
| console.log("You have 10 guesses total") | ||
| } | ||
|
|
||
| const quitGame = () => { | ||
| console.log("Have a nice life!") | ||
| console.log("Goodbye!") | ||
| process.exit() | ||
| } | ||
|
|
||
| const startGame = () => { | ||
| if(rls.keyInYN("Do you want to play? Y or N")) { | ||
| gameLoop() | ||
| } else { | ||
| quitGame() | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Logs "Goodbye!" | ||
| * Calls process.exit() to quit the game | ||
| * | ||
| * | ||
| * @returns {undefined} | ||
| */ | ||
| const quitGame = () => { | ||
|
|
||
| } | ||
| // const quitGame = () => { | ||
| // console.log("Goodbye!") | ||
| // process.exit | ||
| // }; | ||
|
|
||
| /** | ||
| * Controls the flow of the game. | ||
| * Should prompt the user to play again once all | ||
| * guesses have been made or correct answer guessed | ||
| * | ||
| * | ||
| * @returns {undefined} | ||
| */ | ||
| const gameLoop = () => { | ||
|
|
||
| } | ||
|
|
||
| // const gameLoop = () => {}; | ||
|
|
||
| /*** | ||
| * Generates a random number | ||
| * Generates a random number | ||
| * | ||
| * @returns {number} - a number between 1 and 1000 | ||
| */ | ||
| const generateRandomNumber = () => { | ||
| return Math.floor(Math.random()*1000) | ||
| }; | ||
|
|
||
| } | ||
|
|
||
| startGame() | ||
| startGame(); | ||
|
|
||
| module.exports = { | ||
| startGame, | ||
| quitGame, | ||
| gameLoop, | ||
| generateRandomNumber | ||
| } | ||
| generateRandomNumber, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| const readlineSync = require("readline-sync") | ||
|
|
||
| const name = readlineSync.question("What's your name? ") | ||
| console.log("Hi " + name + " nice to meet you!") | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you reordered your functions instead of just changing to ES5 in order to call them later in your startGame function