Conversation
|
Any plans of merge that pull request ;) ? |
|
Hi, well not the gitignore and new option. Don't want this to become a frankenstein. If people want specific features for whatever reason, then they can fork the project to scratch a niche itch. However the typo fixes are welcome. I think I fixed some of those when I addressed a different issue, but see there are still some left. Like eposide and DeNiro :) So if you can reduce the PR to only the remaining such issues, I'd be happy to merge. |
970ad6d to
76bb467
Compare
|
To shortcircuit all this since I was already having this project open for the time being, I've fixed the typos you noted. Thanks for that! I think this PR can be closed as the other aspects I've already commented on. Next time, please open an Issue first to describe why a PR is warranted and what use project it's trying to solve. |
|
@jojje thanks for the comments,
I was thinking of adding PRs to add support for python f'strings and |
76bb467 to
11121f1
Compare
|
I see, thanks for the problem definitions. As to 1, I see the point. Sure, add those. I'll probably add "py-build" stuff (egg info etc) as well, as those tend to clutter up the workspace. The justification would be good DX ergonomics Re #2, I see. Didn't know argparse was clever about this. Now I understand why you changed the string delimiters. Ok, sounds good; justification being that it avoids similar unintentional whitespace collapses in the future when output text is edited. One Ask though, please used double-quotes in the triple form. I.e. Please create two separate PRs for these, since they tackle two orthogonal concerns. Now, finally as to your "docker" concern. There are other ways to solve that. Most common is to store any data one wants persisted (such as the database itself) on a There are of course other ways someone might want to solve that problem; that's what I meant that this sort of feature is likely to be very user-specific as per how they want to cleanup, archive, version etc the data source files from imdb. |

This PR: