Adding flexible update getProgress and getUpdateSize#94
Open
nikb7 wants to merge 5 commits intojonasbark:masterfrom
Open
Adding flexible update getProgress and getUpdateSize#94nikb7 wants to merge 5 commits intojonasbark:masterfrom
nikb7 wants to merge 5 commits intojonasbark:masterfrom
Conversation
jonasbark
reviewed
Feb 21, 2023
| } | ||
|
|
||
| private fun getFlexibleUpdateProgress(result: Result) = checkAppState(result) { | ||
| result.success(flexibleUpdateProgress) |
Owner
There was a problem hiding this comment.
a stream would be nicer, but this should be good enough - thanks! Will merge soon
Author
There was a problem hiding this comment.
Hey, any timeline around merging this?
|
Hi @jonasbark Any reason it's abandoned? |
Owner
|
yes, there are merge conflicts and I'd prefer the progress to be a stream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used to easily show user how much app update has been downloaded in background.
Upgraded flutter version to 3.7