Skip to content

enable listening on IPv6#99

Open
toddjcrane wants to merge 1 commit intojonashaag:masterfrom
toddjcrane:ipv6
Open

enable listening on IPv6#99
toddjcrane wants to merge 1 commit intojonashaag:masterfrom
toddjcrane:ipv6

Conversation

@toddjcrane
Copy link
Copy Markdown

small modification to allow listening on IPv6 addresses

@toddjcrane
Copy link
Copy Markdown
Author

I still need to write tests for this

@jonashaag
Copy link
Copy Markdown
Owner

Hi thanks for the patch. Minor things:

  • how do I listen on all IPv4 interfaces? With your code it's possible to only listen on all IPv6 interfaces if I understand it correctly
  • there's repeated code there that can easily be put into a function or conditional statement

Tests aren't really necessary, just look at all the other test cases, none if them are actual tears, more like examples...

@toddjcrane
Copy link
Copy Markdown
Author

To listen on all IPv4, listen on 0.0.0.0
I thought about it and decided to set the default to listen on IPv6 as listening on all IPv6 will also listen on all IPv4. Also, there was a bit of a (not so) hidden agenda to further IPv6 enable the internet.

I'll make the refactoring changes to eliminate repetitive code and I'll have it up here shortly

@holms
Copy link
Copy Markdown

holms commented Jan 16, 2017

Can this be confirmed please?

@jonashaag
Copy link
Copy Markdown
Owner

The patch needs some minor refactoring before it can be landed.

@tambry tambry mentioned this pull request Mar 17, 2018
@danigosa danigosa mentioned this pull request Jun 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants