Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to integrate a job queue into the bot functionality to manage task scheduling such as basetime updates, caching plots, and broadcasting. Key changes include:
- Removing old threading/asyncio functions and replacing them with job queue scheduling in bot startup.
- Adding constants (JOBQUEUE_DELAY, DEFAULT_USER_ID) to support job queue behavior.
- Modifying the PlotBot class to schedule periodic jobs for basetime override, basetime updates, caching, and broadcasting.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main.py | Removed legacy async/threading constructs and updated bot startup logic. |
| constants.py | Introduced JOBQUEUE_DELAY and DEFAULT_USER_ID constants. |
| bot.py | Replaced manual loop-based scheduling with job queue based scheduling. |
Comments suppressed due to low confidence (1)
bot.py:342
- Ensure that JOBQUEUE_DELAY (from constants.py) is appropriately tuned for the use case and that the use of run_once with an asynchronous callback (_send_plot_from_queue) is consistent with the synchronous expectations of the job queue scheduler.
context.job_queue.run_once(self._send_plot_from_queue,
Comment on lines
+53
to
56
| # we should not be here | ||
| sys.exit(1) | ||
|
|
||
|
|
There was a problem hiding this comment.
The comment '# we should not be here' together with sys.exit(1) could lead to confusion if bot.start() blocks indefinitely. Consider clarifying the intended control flow or removing unreachable code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.