Fix WebAssembly play boot#283
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR defers game startup until after the Emscripten runtime fully initializes. The Makefile disables automatic entry invocation and exports callMain, the C code refactors gameplay startup into a reusable helper, and both web entry points (Dashboard and shell.html) defer calling Module.callMain() until onRuntimeInitialized fires. ChangesDeferred Game Initialization
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
GameStateoff the native/WASM stack and onto the heap to avoid Emscripten stack overflow / WASM memory trapssuper-mango.htmlbootable whenINVOKE_RUN=0is usedTest Plan
git diff --checkmake webbun run buildindocs/make smokebun run lintindocs/(Astro check completed with generated-output hints only)Summary by CodeRabbit