Fix compiler warnings across the project

[Copilot]

Several compiler warnings were present across the codebase, spanning obsolete API usage, incorrect value-type identity comparisons, stale XML doc comments, and an unassigned variable capture.

Changes

• SYSLIB0051 (ContractHelpers.cs): Remove obsolete [Serializable] + SerializationInfo/StreamingContext constructor from private AssertionException; unused in .NET 10.

• CA2013 (SwitchFlow.cs, ReturnFlow.cs): Replace object.ReferenceEquals with .Equals for Instruction (a value type) — boxing makes ReferenceEquals always return false.

  // Before
  if (object.ReferenceEquals(newSwitchValue, SwitchValue))
  // After
  if (newSwitchValue.Equals(SwitchValue))

• CS0618 — Loyc API renames (EncoderState.cs, TypeCodec.cs, InstructionCodecElements.cs, DecoderState.cs):

  • EmptySourceFile.Default → EmptySourceFile.Synthetic
  • CodeSymbols.PtrArrow → CodeSymbols.RightArrow
  • CodeSymbols.Switch → CodeSymbols.SwitchStmt (encoder + decoder)
  • LNodeFactory.List(...) → LNodeFactory.AltList(...)

• CS0618 — CustomLiteral (ConstantCodec.cs): Encode integer literals using the new Factory.Literal(value, symbol) overload with TypeMarker. Decoder updated to read node.TypeMarker directly, with a pragma-suppressed fallback for old CustomLiteral-encoded nodes.

• CS1572/CS1573 (ClrMethodBodyAnalyzer.cs): Fix <param> doc tags referencing non-existent landingPadTag — update to match the actual parameter analyzedHandler.

• CS8887 (DeferredInitializerTests.cs): Initialize init to default before it is captured in a recursive lambda.

---

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

[jonathanvdc]

Good work but this fails on the portable test suite. e.g., try the OptimizeRecursiveMethod test

[Copilot]

Good work but this fails on the portable test suite. e.g., try the OptimizeRecursiveMethod test

Fixed in 760f0ca. The issue was in TryDecomposeCustomLiteral — LES-parsed plain integers like 0 and 1 have a TypeMarker of '_' (not null, but the default "no type marker" symbol), so they incorrectly entered the custom literal branch. Added a guard && node.TypeMarker.Name != "_" to skip nodes with the default type marker.

[jonathanvdc]

Looks great!