Skip to content

Remove unnecessary System.Collections.Immutable package references#45

Merged
jonathanvdc merged 2 commits intomasterfrom
copilot/remove-unnecessary-package-reference
Mar 28, 2026
Merged

Remove unnecessary System.Collections.Immutable package references#45
jonathanvdc merged 2 commits intomasterfrom
copilot/remove-unnecessary-package-reference

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 28, 2026

System.Collections.Immutable is part of the .NET 10 SDK and doesn't need to be explicitly referenced, producing warning NU1510 across multiple projects.

Changes

  • Removed PackageReference for System.Collections.Immutable from all projects targeting only net10.0: Flame.Clr, Flame.Ir, Flame.Llvm, ILOpt, IL2LLVM, Brainfuck, UnitTests
  • Conditionalized the reference in Flame.Compiler (multi-targets net10.0;netstandard2.0;net472) to only apply for the older frameworks where the package isn't SDK-included:
<PackageReference Include="System.Collections.Immutable"
    Condition="'$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'net472'" />

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • http://api.nuget.org:443/sha2-assured-cs-g1.crl
    • Triggering command: /usr/bin/dotnet dotnet build Flame.sln (http block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove unnecessary package reference for System.Collections.Immutable Remove unnecessary System.Collections.Immutable package references Mar 28, 2026
Copilot AI requested a review from jonathanvdc March 28, 2026 18:46
@jonathanvdc jonathanvdc marked this pull request as ready for review March 28, 2026 18:59
@jonathanvdc jonathanvdc merged commit bae7d4e into master Mar 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants