Make all WriteTo methods in MLIR.Syntax public; remove Action callbacks#10
Merged
jonathanvdc merged 2 commits intomainfrom Mar 29, 2026
Merged
Make all WriteTo methods in MLIR.Syntax public; remove Action callbacks#10jonathanvdc merged 2 commits intomainfrom
jonathanvdc merged 2 commits intomainfrom
Conversation
…backs Agent-Logs-Url: https://github.com/jonathanvdc/MLIR.NET/sessions/33d95447-a063-48cc-8975-b15643d702c3 Co-authored-by: jonathanvdc <9839946+jonathanvdc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make all WriteTo methods public and clean up code
Make all WriteTo methods in MLIR.Syntax public; remove Action callbacks
Mar 29, 2026
jonathanvdc
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
WriteTomethods on MLIR syntax nodes wereinternal, and several acceptedAction<>delegate callbacks to handle recursive writing — making them awkward to call externally and tightly coupled toSyntaxWriterinternals.Changes
MLIR.Syntaxnodes — promotedWriteToonBlockArgumentSyntax,BlockSyntax,ModuleSyntax,OperationSyntax, andRegionSyntaxfrominternaltopublic; added XML doc commentsAction<>parameters —OperationBodySyntax,GenericOperationBodySyntax,OperationSyntax,RegionSyntax, andBlockSyntaxno longer accept write-region/write-operation callbacks; recursive writes now callwriter.WriteRegion/writer.WriteOperationdirectlySyntaxWriter— removed the now-redundant static lambda adapters fromWriteOperation,WriteRegion, andWriteBlockDialectSourceEmitter) — updated the emittedWriteTooverride signature to matchOperationBodySyntaxsubclasses and the generator snapshot assertionBefore:
After:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.