Emit concrete OperationBodySyntax subclass per operation with declarative assembly format#9
Merged
jonathanvdc merged 2 commits intomainfrom Mar 29, 2026
Conversation
…es for operations with assembly formats Agent-Logs-Url: https://github.com/jonathanvdc/MLIR.NET/sessions/8c4f0d04-0e04-4697-9f1c-86e836772c76 Co-authored-by: jonathanvdc <9839946+jonathanvdc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add concrete syntax tree class generation for operations
Emit concrete OperationBodySyntax subclass per operation with declarative assembly format
Mar 29, 2026
jonathanvdc
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialectSourceEmitterpreviously had no CST representation for operations with declarative assembly formats — only anIOperationAssemblyFormatstub. This adds a generated{ClassName}BodySyntax : OperationBodySyntaxclass whose fields mirror the token/sub-CST sequence in the operation'sAssemblyFormatModel.Generated class structure
For
$lhs,$rhs attr-dict:type($result), the emitter now produces:Element-to-field mapping
SyntaxTokenSyntaxTokenAttributeValueSyntaxattr-dict/attr-dict-with-keyword/prop-dictDelimitedSyntaxList<NamedAttributeSyntax>regionsIReadOnlyList<RegionSyntax>type(...)TypeSyntaxsuccessors/operandsDelimitedSyntaxList<SyntaxToken>Complex elements (optional groups, oilist, custom directives) are not stored —
WriteToomits them silently for now.Related change
NamedAttributeSyntax.WriteTopromoted frominternaltopublicso generated consumer assemblies can call it when serialising attribute dictionaries.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.