This fixes (IIRC) the dynamics of the pod under reverse gravity - i.e. it makes reverse gravity affect the pod too.#2
Open
paulhirst wants to merge 1 commit intojoncombe:masterfrom
Conversation
…lue, so that reverse gravity acts correctly on the pod
|
Yes. I was just having fun playing this, but I couldn't quite put my finger on what was wrong when I first got to the reverse gravity. But yes, the reverse gravity is not reversed for the pod! (or the "toilet seat" as we used to call it when I was little). In fact you can weirdly hover with the weight of the pod pulling down while the gravity pulls the ship upwards. That's not supposed to happen! And I just tested this fix. It works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated classShip.js to apply game gravity to pod rather than the fixed 0.1 value, so that reverse gravity acts correctly on the pod. It's been a while since I played the original, but IIRC correctly, this brings the dynamics closer to the original game play in the reverse gravity levels.
I appreciate this is slightly more than "reversing" gravity on the pod, as the gravity levels throughout the game are slightly different to the previous 0.1 fixed value, however my feeling was that the pod felt slightly heavier in the original too, so I figured this simple fix would address that too.
Many thanks for making this excellent recreation available! I hope I'm not mis-remembering the original in suggesting this quick fix.