Skip to content

[WIP] Fix failing GitHub Actions job build-test-pack#181

Merged
jongalloway merged 3 commits into
mainfrom
copilot/fix-build-test-pack-job
Jun 21, 2026
Merged

[WIP] Fix failing GitHub Actions job build-test-pack#181
jongalloway merged 3 commits into
mainfrom
copilot/fix-build-test-pack-job

Conversation

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Fix the failing GitHub Actions job "build-test-pack"
Analyze the Actions logs, identify the root cause of the failure, and implement a fix.
Check run ID: 82531174580
Job URL: https://github.com/jongalloway/MarpToPptx/actions/runs/27889779720/job/82531174580

Copilot AI requested a review from jongalloway June 21, 2026 01:47
@jongalloway jongalloway marked this pull request as ready for review June 21, 2026 02:07
@jongalloway jongalloway requested a review from Copilot June 21, 2026 02:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the failing CI job build-test-pack by hardening SyntaxHighlighter against non-thread-safe behavior in TextMateSharp that was causing SyntaxHighlighterTests.Tokenize_CSharp_ProducesColoredRunsForKeywords to fail with a NullReferenceException.

Changes:

  • Serialize TextMateSharp registry/grammar usage by expanding the existing lock to cover both grammar loading and tokenization.
  • Add a defensive null-check around grammar.TokenizeLine(...) to prevent NullReferenceException when a null result is returned.
  • Update the inline comment to document the broader thread-safety constraints (registry + grammar instances).
Show a summary per file
File Description
src/MarpToPptx.Pptx/Rendering/SyntaxHighlighter.cs Serializes TextMateSharp operations and adds a null-guard to avoid CI test failures due to unexpected null tokenization results.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/MarpToPptx.Pptx/Rendering/SyntaxHighlighter.cs
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jongalloway jongalloway merged commit 6e6c0d7 into main Jun 21, 2026
5 checks passed
@jongalloway jongalloway deleted the copilot/fix-build-test-pack-job branch June 21, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants