misc code cleanup / add more static typing#6
Open
EmilyV99 wants to merge 1 commit intojonloveslegos:mainfrom
Open
misc code cleanup / add more static typing#6EmilyV99 wants to merge 1 commit intojonloveslegos:mainfrom
EmilyV99 wants to merge 1 commit intojonloveslegos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was looking for causes of lag (see other PR), I cleaned up a bunch of code and added more static typing. Feel free to merge if you like, or close if you don't want, nothing here should be specifically urgent. Feel free to ask any questions about anything changed here if you want specific reasoning.
Unlike the other PR, I don't believe this to be urgent in any way.