Conversation
… tparm, tgoto, which cause a core dump or compile errors under certain environments, e.g. CentOS7) no longer use -u on jmake since it causes a spurious failure in some situations
…code) removed all declarations that would appear in C89 or POSIX.1 standard headers (I think POSIX.1 1988 ought to be fine, though hard to say since all machines I can test are far more modern and conform to 2001) restored JSSIZE_T so Windows builds again. Tweaks to testbuild.sh to test mingw and pipeprocs.
USE_GETWD/USE_PWD, WAIT3 or BSD_WAIT.
doubt c2x Jove compiles/works on it anyway, old systems need to stay with 4.17.
had either better have fstat+fchmod or declare ttyname in unistd.h)
incorrect parens around a few 'extern char*' decls (most importantly: tparm, tgoto, which cause a core dump or compile errors under certain environments, e.g. CentOS7) no longer use -u on jmake since it causes a spurious failure in some situations
…l versions of C (clang19)
error: a function declaration without a prototype is deprecated in al…
c97301d Merge branch 'moraes/pr_jove_c2x_badparen' into c2x
… tparm, tgoto, which cause a core dump or compile errors under certain environments, e.g. CentOS7) no longer use -u on jmake since it causes a spurious failure in some situations
…code) removed all declarations that would appear in C89 or POSIX.1 standard headers (I think POSIX.1 1988 ought to be fine, though hard to say since all machines I can test are far more modern and conform to 2001) restored JSSIZE_T so Windows builds again. Tweaks to testbuild.sh to test mingw and pipeprocs.
USE_GETWD/USE_PWD, WAIT3 or BSD_WAIT.
doubt c2x Jove compiles/works on it anyway, old systems need to stay with 4.17.
had either better have fstat+fchmod or declare ttyname in unistd.h)
…l versions of C (clang19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ok i've rebased c2x on current 4_17, which involved resolving conflicts for every single change previously made in the c2x branch.
i think we should not be working from the 4_17 branch, but rather, should work on 'main' or 'master'. 4.17 isn't going to be shipped again, so we should not be committing there. so if possible, reject this PR, create 'main' or 'master' from HEAD, and i'll rebase c2x against 'main' or 'master' and request a PR there. later on we can branch from 'main' or 'master' to create 5_0.
no matter what, we need to get these changes committed before we evolve the editor further.