fix: publicApiUrl deployment configuration and optimize auth provider tests

apps/api/src/services/oauth/provider.test.ts

@@ -0,0 +1,50 @@
+import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import { getCallbackUrl } from "./provider.js";
+
+describe("getCallbackUrl", () => {
+  const originalEnv = { ...process.env };
+
+  beforeEach(() => {
+    // Clear relevant environment variables before each test
+    delete process.env.PUBLIC_URL;
+    delete process.env.PUBLIC_API_URL;
+    delete process.env.API_PORT;
+  });
+
+  afterEach(() => {
+    // Restore original environment
+    process.env = { ...originalEnv };
+  });
+
+  describe.each(["github", "google", "oidc"])("with provider %s", (provider) => {
+    it("uses PUBLIC_URL when it is set and PUBLIC_API_URL is not", () => {
+      process.env.PUBLIC_URL = "https://optio.example.com";
+      expect(getCallbackUrl(provider)).toBe(
+        `https://optio.example.com/api/auth/${provider}/callback`,
+      );
+    });
+
+    it("uses PUBLIC_API_URL when it is set", () => {
+      process.env.PUBLIC_API_URL = "https://optio-api.example.com/api";
+      expect(getCallbackUrl(provider)).toBe(
+        `https://optio-api.example.com/api/auth/${provider}/callback`,
+      );
+    });
+
+    it("uses PUBLIC_API_URL and trims trailing slash", () => {
+      process.env.PUBLIC_API_URL = "https://optio-api.example.com/api/";
+      expect(getCallbackUrl(provider)).toBe(
+        `https://optio-api.example.com/api/auth/${provider}/callback`,
+      );
+    });
+
+    it("falls back to localhost with API_PORT when PUBLIC_URL is not set", () => {
+      process.env.API_PORT = "8080";
+      expect(getCallbackUrl(provider)).toBe(`http://localhost:8080/api/auth/${provider}/callback`);
+    });
+
+    it("falls back to localhost:4000 when neither PUBLIC_URL nor API_PORT are set", () => {
+      expect(getCallbackUrl(provider)).toBe(`http://localhost:4000/api/auth/${provider}/callback`);
+    });
+  });
+});

apps/api/src/services/oauth/provider.ts

@@ -21,6 +21,10 @@ export interface OAuthProvider {
 }
 
 export function getCallbackUrl(provider: string): string {
+  if (process.env.PUBLIC_API_URL) {
+    const base = process.env.PUBLIC_API_URL.replace(/\/$/, "");
+    return `${base}/auth/${provider}/callback`;
+  }
   const base = process.env.PUBLIC_URL ?? `http://localhost:${process.env.API_PORT ?? 4000}`;
   return `${base}/api/auth/${provider}/callback`;
 }

helm/optio/templates/api-deployment.yaml

@@ -92,6 +92,16 @@ spec:
               value: "0.0.0.0"
             - name: OPTIO_API_INTERNAL_URL
               value: "http://{{ .Release.Name }}-api:{{ .Values.api.port }}"
+            {{- if .Values.web.publicApiUrl }}
+            - name: PUBLIC_API_URL
+              value: {{ .Values.web.publicApiUrl | quote }}
+            {{- else if .Values.publicUrl }}
+            - name: PUBLIC_API_URL
+              value: "{{ trimSuffix "/" .Values.publicUrl }}/api"
+            {{- else if and (eq .Values.api.service.type "NodePort") .Values.api.service.nodePort }}
+            - name: PUBLIC_API_URL
+              value: "http://localhost:{{ .Values.api.service.nodePort }}"
+            {{- end }}
             - name: NODE_ENV
               value: "production"
             - name: LOG_LEVEL

helm/optio/templates/web-deployment.yaml

@@ -79,6 +79,9 @@ spec:
             {{- if .Values.web.publicApiUrl }}
             - name: PUBLIC_API_URL
               value: {{ .Values.web.publicApiUrl | quote }}
+            {{- else if .Values.publicUrl }}
+            - name: PUBLIC_API_URL
+              value: "{{ trimSuffix "/" .Values.publicUrl }}/api"
             {{- else if and (eq .Values.api.service.type "NodePort") .Values.api.service.nodePort }}
             - name: PUBLIC_API_URL
               value: "http://localhost:{{ .Values.api.service.nodePort }}"

helm/optio/values.yaml

@@ -96,6 +96,8 @@ web:
     maxReplicas: 4
     targetCPUUtilizationPercentage: 70
     targetMemoryUtilizationPercentage: ""
+  # Optional override for the public API URL (defaults to PUBLIC_URL with /api path)
+  publicApiUrl: ""
 
 # ──────────────────────────────────────────────────────────────────────────────
 # Optio Operations Assistant Pod