CategoriesHelper is from Administrator, not from Site

[HermanPeeren]

Pull Request for Issue # .

Summary of Changes

Joomla\Component\Categories\Site\Helper\CategoriesHelper doesn't exist, should be Joomla\Component\Categories\Administrator\Helper\CategoriesHelper.

Didn't make an issue of it first, but looks obvious to me, as there is no com_categories at the Site, only at the Administrator.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

[HermanPeeren]

Three different things are happening here:

• This PR is a simple correction of a bug (using a non-existent class). Weblinks won't run with this bug; it will give a fatal error.
• Besides this bug there are dozens of deprecated code in Weblinks. These will give warnings, but no fatal error. Wanted to correct that in a separate PR. But now in the CI those deprecations cause failed tests. The current 5.0.0 release still has all that deprecated code.
• the CI is broken: some dependencies for the tests require PHP>= 8.3, but you also test them on 8.1 and 8.2, and that fails. Also the tests are cancelled after three minutes.

I think the way out here is:

• merge this PR (manually check it yourself or just try to run Weblinks 5.0.0 in a Joomla 5 or 6 instance and see that this works).
• I will make a PR for all that deprecated code. Or did you already have something for that? Thought that would be done in the GSoC project, but apparantly it is not yet in this repo.
• repair the CI if you want to test on php 8.1 and 8.2, and not being cancelled after 3 minutes.

[alikon]

thanks for the fix

I will make a PR for all that deprecated code. Or did you already have something for that? Thought that would be done in the GSoC project, but apparantly it is not yet in this repo.

yes please in the GSoC we focused much more on system test

repair the CI if you want to test on php 8.1 and 8.2, and not being cancelled after 3 minutes.

there is a pr #672 i need someone to sign the drone.yml and i'll merge

[alikon]

p.s.
some work was made in that direction #612