Skip to content

[4.0] Update SASS to 1.42 - #35666

Merged
wilsonge merged 1 commit into
joomla:4.0-devfrom
dgrammatiko:4.0-dev-sass-upd
Sep 28, 2021
Merged

[4.0] Update SASS to 1.42#35666
wilsonge merged 1 commit into
joomla:4.0-devfrom
dgrammatiko:4.0-dev-sass-upd

Conversation

@dgrammatiko

Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Summary of Changes

Update SASS to 1.42

Testing Instructions

Clone run npm install and check that both the front end and back end templates are intact

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

The Pr #35648 is actually eliminating the deprecations but this PR will allow the compiler not to throw...

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 25, 2021
@dgrammatiko

Copy link
Copy Markdown
Contributor Author

@thednp could you test this one? Will solve the failing tests on your color picker PR

@thednp

thednp commented Sep 25, 2021

Copy link
Copy Markdown
Contributor

Testing right now. I was thinking I should revert most minicolors deletions to see if I can just get away from the compiler issue.

@thednp

thednp commented Sep 25, 2021

Copy link
Copy Markdown
Contributor

Result: in my local setup, sass v1.42.0 doesn't solve the problem with the color-picker commit, I will now attempt to re-add minicolors back.

@thednp

thednp commented Sep 26, 2021

Copy link
Copy Markdown
Contributor

Speaking about SASS, have you found a way to create an updated medialize/sass.js build? Or anything up to date to work in the browser?

@dgrammatiko

Copy link
Copy Markdown
Contributor Author

have you found a way to create an updated medialize/sass.js build?

It seems that their tools work fine with latest node-sass: https://github.com/dgrammatiko/sass-worker/tree/master/dist

@thednp

thednp commented Sep 26, 2021

Copy link
Copy Markdown
Contributor

That is so sweet. Thank you

@wilsonge

Copy link
Copy Markdown
Contributor

Even if it doesn't help on that issue it's still a valid dependency update so will merge

@wilsonge
wilsonge merged commit 66df66d into joomla:4.0-dev Sep 28, 2021
@wilsonge wilsonge added this to the Joomla 4.0.4 milestone Sep 28, 2021
@dgrammatiko
dgrammatiko deleted the 4.0-dev-sass-upd branch September 29, 2021 06:44
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Oct 3, 2021
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Oct 3, 2021
ditsuke pushed a commit to ditsuke/joomla-cms that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants