Removed depriciation warnings in scss - #36992
Closed
HarshJaiswani wants to merge 3 commits into
Closed
Conversation
joomla-cms-bot
added
NPM Resource Changed
Member
|
@dgrammatiko Shall this PR be closed in favour of #36906 ? |
Contributor
|
This does not eliminate all the deprecations, the other PR does |
Member
@HarshJaiswani Would you mind to close this PR in favour of #36906 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #36991 .
Summary of Changes
included "calc" before every bracket where warning occured in scss files
Testing Instructions
hit "npm run build:css" in the root folder the warnings of depriciation will appear
Actual result BEFORE applying this Pull Request
there will be warnings of depreciation in scss
Expected result AFTER applying this Pull Request
only few warnings related to fontawsome will remain in the directory of media\vendor rest all warnings will be cleared
Documentation Changes Required
no