Skip to content

[4.1] Remove the math.div deprecation - #37255

Merged
bembelimen merged 10 commits into
joomla:4.1-devfrom
dgrammatiko:4.1-dev-sass-deprecations
Mar 17, 2022
Merged

[4.1] Remove the math.div deprecation#37255
bembelimen merged 10 commits into
joomla:4.1-devfrom
dgrammatiko:4.1-dev-sass-deprecations

Conversation

@dgrammatiko

Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Kinda replaces #36906 (no FA upgrade to v6)

Summary of Changes

  • patch the font awesome files
  • local fixes

Testing Instructions

  • Apply this Pr's branch
  • run npm ci
  • Check that nothing is broken visually and there are no console deprecation when running any node (css related) cli command

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Mar 12, 2022
Comment thread build/build-modules-js/init/patches.es6.js Outdated
@brianteeman

brianteeman commented Mar 12, 2022

Copy link
Copy Markdown
Contributor

I can confirm that the deprecation notices have now gone

Is it intentional that the joomla.asset.json files no longer have a version hash?

Commented on the code where there is an error in your math

Co-authored-by: Brian Teeman <brian@teeman.net>
@brianteeman

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 5f01580

Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37255.

@dgrammatiko

dgrammatiko commented Mar 12, 2022

Copy link
Copy Markdown
Contributor Author

Is it intentional that the joomla.asset.json files no longer have a version hash?

The hash is not generated automatically per npm ci, you need to run specifically npm run versioning. (the reason is because for development having to invalidate this hash every time you apply some changes in any of the css/js would be an extra step which will be a way slower workflow)

@richard67

Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 5f01580


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37255.

@richard67 richard67 changed the title [4.1] Remove the math.div deprecation [4.1] Remove the math.div deprecation Mar 14, 2022
@richard67

Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37255.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 14, 2022
@bembelimen
bembelimen merged commit 863e170 into joomla:4.1-dev Mar 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2022
@bembelimen

Copy link
Copy Markdown
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.1 milestone Mar 17, 2022
@dgrammatiko
dgrammatiko deleted the 4.1-dev-sass-deprecations branch March 17, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants