[5.0] Update deleted files and folders to changes of today and delete 4.4 update SQL scripts - #40676
Merged
HLeithner merged 4 commits intoMay 29, 2023
Conversation
richard67
marked this pull request as ready for review
May 29, 2023 11:52
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the lists of deleted files and folders in script.php to the latest changes from PRs #40524 , #40626 and #40674 .
In addition, it fixes inconsistent ordering in the list of deleted files. It should always be ordered case-insensitive in ascending order, and the list of folders should always be case-insensitive in descending order.
It also removes entries from the lists which have become obsolete due to dependency updates. As long as we haven't released alpha 1 yet, there is no need to keep them.
Finally it removes the 4.4 update SQL scripts which have been added by mistake with the last upmerge.
Testing Instructions
Code review.
Or if you want to make a real test, update the last 4.4 nightly build to the last 5.0 nightly build to get the actual result, and update the last 4.4 nightly build to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
The following files are still present after the update:
Besides this there are also the following files present, and they would also be included in a new installation:
Expected result AFTER applying this Pull Request
The files mentioned in the previous section "Actual result BEFORE applying this Pull Request" are not present after an update.
Folders "/media/vendor/tinymce/plugins/template" and "/libraries/vendor/psr/http-message/docs" have been removed completely.
The "4.4.0-2023-05-08.sql" files are not included in the full package for a new installation or the update package and removed from the sources with this PR.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed