Skip to content

[6.2] Implement link selector dialog for tinymce - #48138

Merged
drmenzelit merged 2 commits into
joomla:6.2-devfrom
bembelimen:6.2/link-selector
Aug 3, 2026
Merged

[6.2] Implement link selector dialog for tinymce#48138
drmenzelit merged 2 commits into
joomla:6.2-devfrom
bembelimen:6.2/link-selector

Conversation

@bembelimen

@bembelimen bembelimen commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Based on #48043 this implements now a selector for the tinyMCE link where editor-xtd plugins can inject themself and links can be added.

Testing Instructions

  • Activate TinyMCE and the xtd-editor buttons (enabled by default).
  • Create a new article
  • insert a link via TinyMCE
grafik

Actual result BEFORE applying this Pull Request

grafik

Just an input field to type in a link.

Expected result AFTER applying this Pull Request

grafik

The input field now has a "Browse links" button to click. When clicking a dialog opens and you can select between articles/contacts/menus/media to insert as link.

grafik

Link to documentations

Please select:

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-6.2-dev labels Jul 22, 2026
@brianteeman

brianteeman commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

does it generate the links in the same way as the xtd-editor buttons?

if it does maybe we can think about not enabling them by default anymore for tinymce users

maybe we can look at removing the xtd-buttons from the tinymce toolbar now on new installs

@brianteeman

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on c8076ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48138.

@laoneo

laoneo commented Jul 23, 2026

Copy link
Copy Markdown
Member

Cool, can every extension who has a button hook in then? If yes, then this should be documented.

@brianteeman

Copy link
Copy Markdown
Contributor

Cool, can every extension who has a button hook in then? If yes, then this should be documented.

looks like it - just a few extra lines into your button

@ThomasFinnern

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on c8076ff

I tested html, article, contact, menus, media - links


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48138.

@CSGoat0

CSGoat0 commented Jul 24, 2026

Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on c8076ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48138.

@richard67

Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48138.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 24, 2026
@bembelimen

bembelimen commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Cool, can every extension who has a button hook in then? If yes, then this should be documented.

Added

@laoneo

laoneo commented Jul 28, 2026

Copy link
Copy Markdown
Member

I'm currently testing it with DPCalerndar. Works good so far, just wondering, in the button we use a link with the session form token:
$link = 'index.php?option=com_contact&view=contacts&layout=modal&tmpl=component&' . Session::getFormToken() . '=1&editor=' . $name;

but not in the script option. Is this done on purpose?

@MacJoom MacJoom added this to the Joomla! 6.2.0 milestone Aug 3, 2026
@drmenzelit
drmenzelit merged commit 23713fe into joomla:6.2-dev Aug 3, 2026
145 of 162 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 3, 2026
@drmenzelit

Copy link
Copy Markdown
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants