Skip to content

[5.4] Correct subpackage - #48181

Merged
richard67 merged 4 commits into
joomla:5.4-devfrom
brianteeman:subpackage
Aug 2, 2026
Merged

[5.4] Correct subpackage#48181
richard67 merged 4 commits into
joomla:5.4-devfrom
brianteeman:subpackage

Conversation

@brianteeman

Copy link
Copy Markdown
Contributor

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

corrects the value of @subpackage

Testing Instructions

code review only

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 4bcdb42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48181.

@QuyTon

QuyTon commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

There are several instances of the same filename where it is com_content. I don't know which is correct.

@brianteeman

Copy link
Copy Markdown
Contributor Author

Sorry I don't understand you

@QuyTon

QuyTon commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Do a search on modalreturn.php in the file system.

In the following, the subpackage is com_content.
\administrator\components\com_plugins\tmpl\plugin\modalreturn.php

@brianteeman

brianteeman commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Then that is also wrong but beyond the scope of this pr and i have added them to this pr

@alikon

alikon commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 110aa3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48181.

@LadySolveig

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 110aa3b

review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48181.

@alikon

alikon commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48181.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 2, 2026
@richard67 richard67 added this to the Joomla! 5.4.8 milestone Aug 2, 2026
@richard67
richard67 merged commit ac34289 into joomla:5.4-dev Aug 2, 2026
76 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 2, 2026
@richard67

Copy link
Copy Markdown
Member

Thanks @brianteeman for this PR, @QuyTon for review, and @LadySolveig and @alikon for testing/review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants