[6.2] Admin menu Custom Support Link - #48186
Open
brianteeman wants to merge 2 commits into
Open
Conversation
In Joomla 3 we had a drop down help menu that included the possibility for a custom admin help link Since Joomla 4 that dropdown help menu has been replaced by the complete help dashboard which is not customisable For custom support links etc we added a specific module called login support This PR removes the configuration option in the admin module to display a link. It confused users who tried to set up a custom link here and it did not get displayed anywhere (It could only be displayed if you were using the alternate preset) This PR removes the option in the admin menu module to add a custom link
Contributor
|
I have tested this item ✅ successfully on 45264d1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48186. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves #39967
Summary of Changes
In Joomla 3 we had a drop down help menu that included the possibility for a custom admin help link
Since Joomla 4 that dropdown help menu has been replaced by the complete help dashboard which is not customisable
For custom support links etc we added a specific module called login support
The admin menu module still has the field for adding the link but that link will only ever be shown if you are using the alternate preset.
This PR hides the field (to avooid confusion) using showon unless the alternate preselect is selected
Testing Instructions
In the admin menu module enter a value in the field. Observe that the link is never displayed
Change the module to use the alternate preset and observe the link is displayed in the long help menu
Apply this PR and the field is only displayed in the module form when alternate is selected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed