Echo relevant info from mpc status in interactive simple-mpc* functions#16
Open
josephmturner wants to merge 17 commits intojorenvo:masterfrom
Open
Echo relevant info from mpc status in interactive simple-mpc* functions#16josephmturner wants to merge 17 commits intojorenvo:masterfrom
mpc status in interactive simple-mpc* functions#16josephmturner wants to merge 17 commits intojorenvo:masterfrom
Conversation
Contributor
Author
|
Oh, hmm, I didn't realize that pushing to my master branch would add more to this PR, but I guess that's okay. The last commit adds functionality for toggling single status. |
Contributor
Author
|
Forgot the copyright notice. |
josephmturner
changed the title
mpc status in interactive simple-mpc* functions
josephmturner
force-pushed
the
master
branch
from
370d443 to
ca083d0
Compare
Contributor
Author
|
I moved the code which displayed the full stdout of I've not yet noticed any bugs in the remaining code. |
I think this macro makes it easier to read what's going on.
josephmturner
force-pushed
the
master
branch
3 times, most recently
from
eb2cc6c to
c9aeb85
Compare
This is more robust and easier than using buffer movements.
Replaces simple-mpc-message-current-volume.
Replaces simple-mpc-get-current-playlist-position.
Replaces simple-mpc-get-amount-of-songs-in-playlist.
josephmturner
force-pushed
the
master
branch
from
c9aeb85 to
40406f7
Compare
Contributor
Author
|
I rewrote this functionality to extract bits of information from mpc status with regular expressions rather than buffer movement. |
Contributor
Author
|
@jorenvo if you decide to merge, I am happy to squash these commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add helper functions to extract specific pieces of information from
mpc statusin a hacky way. Echo the extracted information on relevant commands.Also, display mpc status in the simple-mpc buffer. This functionality could be improved, since it only updated when the buffer is reverted (by pressing
gor callingsimple-mpcagain). Functions which changes the status, e.g.,simple-mpc-toggle, do not update the buffer.