Skip to content

Unicode filename support fixing #203#221

Open
ivorbosloper wants to merge 4 commits intojorgebastida:masterfrom
ivorbosloper:unicode_support
Open

Unicode filename support fixing #203#221
ivorbosloper wants to merge 4 commits intojorgebastida:masterfrom
ivorbosloper:unicode_support

Conversation

@ivorbosloper
Copy link
Copy Markdown

Non-ascii files raise errors, see #203 . On Mac it's more complex because the unicode filenames we read with os.walk() contain different codepoints for the same unicode characters we wrote (https://stackoverflow.com/a/33647372/193886 pointed me in the right direction, unicodedata.normalize() is your friend).

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 15, 2017

Coverage Status

Coverage decreased (-0.08%) to 92.189% when pulling 9528b2b on ivorbosloper:unicode_support into 37aecf5 on jorgebastida:master.

@ivorbosloper
Copy link
Copy Markdown
Author

Eh, tests fail because python 2.6 is tested and the project dependencies fail to install. Can we please switch off travis-ci testing in python 2.6?

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 19, 2017

Coverage Status

Coverage decreased (-0.08%) to 92.189% when pulling 0dac9e7 on ivorbosloper:unicode_support into 37aecf5 on jorgebastida:master.

@ivorbosloper
Copy link
Copy Markdown
Author

Hmmm, root-cause was Pillow > 4.0.0 dropped python 2.6 support. So either drop python 2.6 in this library or set dependency pillow < 4.0.0 .

See https://pillow.readthedocs.io/en/4.3.x/installation.html#notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants