fix: MCP validation bugs, panic elimination, and code quality improvements#14
Merged
josephgoksu merged 9 commits intomainfrom Jan 25, 2026
Merged
Conversation
Bug: handleTaskNext validated trimmed sessionID but passed untrimmed params.SessionID to the downstream API, creating inconsistency between validation and actual usage. Also improved TaskToolParams struct documentation to match PlanToolParams pattern with explicit required-fields-by-action comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleTaskNextwas validating trimmedsessionIDbut passing untrimmedparams.SessionIDto APInextandcurrentactions now validatesession_idis requiredconfig/paths.goto return errors instead of panickingtask_store.goinstead of ignoring themsql.ErrTxDone)TaskCountfield to Plan struct instead of creating empty Task slicesscannerMocktype that was causing lint failuresTest plan
go vet ./...passesstaticcheck ./...passes🤖 Generated with Claude Code