Fix for slide transitions when changing direction - #35
Open
mortenbekditlevsen wants to merge 4 commits into
Open
Fix for slide transitions when changing direction#35mortenbekditlevsen wants to merge 4 commits into
mortenbekditlevsen wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transition for removal used by SwiftUI
is the one that was set when rendering the slide.
This means that when changing navigation direction,
the animation would be wrong for the first transition
after changing direction.
By first updating the transition (causing a re-render
that doesn't change anything but the transition)
And then - in the next render loop - changing the
slide index, then we get the appropriate transition
even when changing directions.
This could be optimized to only perform the sleep
upon changing directions - by remembering the previous
transition direction and testing to see if it's
necessary to change the transition and re-render.