feat(ci): add GitLab issue templates and label-automation triage job#718
Merged
Conversation
Add the GitLab counterpart to the GitHub issue-template work so issues filed
through the GitLab web UI carry the severity/effort/type labels /next-issue
needs for prioritization.
- .gitlab/issue_templates/{Bug Report,Feature Request,Refactor}.md — mirror
the H2 anchors from docs/development/filing-issues.md, apply type/* via a
/label quick action, and embed a machine-readable Triage block.
- .gitlab/triage/triage-policies.yml — gitlab-triage policy that parses the
Triage block into severity/* and effort/* labels (idempotent via
forbidden_labels), flags issues missing either label with needs-triage plus
a note, and clears the flag once fully labeled.
- .gitlab/ci/triage.yml — reusable, schedule-gated CI include that runs the
policy with a pinned gitlab-triage version; documents GITLAB_API_TOKEN and
needs-triage (color D4C5F9, matching the GitHub labeler) setup.
- tests/unit/gitlab-templates.sh — structural guardrails (templates, quick
actions, type-specific + shared anchors, valid Triage defaults, YAML
validity, label coverage, both needs-triage rules).
- docs/development/filing-issues.md — GitLab web-UI filing subsection.
- lefthook.yml — fix the typos pre-push hook to pass files via `xargs -d '\n'`
so paths containing spaces (the new issue templates) are not word-split.
Closes #298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug Report,Feature Request,Refactor) thatmirror the H2 body anchors from
docs/development/filing-issues.md, apply atype/*label via a/labelquick action, and embed a machine-readableTriage block (
- Severity:/- Effort:).gitlab-triagepolicy (.gitlab/triage/triage-policies.yml) that parsesthe Triage block into
severity/*/effort/*labels (idempotent viaforbidden_labels), flags issues missing either label withneeds-triageplus a note, and clears the flag once fully labeled.
.gitlab/ci/triage.yml) that runsthe policy with a pinned
gitlab-triageversion.docs/development/filing-issues.md.typospre-push hook (lefthook.yml) to pass files viaxargs -d '\n'so the spaced template filenames are not word-split.This is the GitLab counterpart to the GitHub issue-template work (split from
#228, superseded by #294). It covers the human web-UI filer path;
/file-issuecovers the agent path. Both apply the identical taxonomy.
Test plan
tests/unit/gitlab-templates.sh— 11 structural assertions (templates,quick actions, shared + type-specific H2 anchors, valid Triage defaults, YAML
validity, full label coverage, both needs-triage rules, schedule gate).
yqvalidates both YAML files;shfmt -i 4 -ci+shellcheckclean on thetest;
typosnow passes on the spaced filenames.Review findings
Pre-PR adversarial review ran (6 of 7 dimensions completed; the 7th agent hung
on a harness stall and was excluded). The one blocking finding — unpinned
gitlab-triagegem executing with an API token — is fixed in this PR (gemversion pinned via
GITLAB_TRIAGE_VERSION). Additional high-certainty findingsfixed here: the
needs-triagelogic now fires when either label is missing(was: only when both absent), the
stibbons labels syncsuggestion forneeds-triagewas corrected (that label is not skill-owned), the label color nolonger collides with
severity/medium, and tests were added for the auto-clearrule, type-specific anchors, and Triage-default validity.
Deferred as follow-ups:
cache, token-in-argv,
allow_failurealerting).gitlab-triageregex conditions against templateTriage blocks.
Closes #298