fix: CustomView added after mount_to is now accessible (#731) - #766
Open
SHYXIN wants to merge 1 commit into
Open
fix: CustomView added after mount_to is now accessible (#731)#766SHYXIN wants to merge 1 commit into
SHYXIN wants to merge 1 commit into
Conversation
When CustomView was added via add_view() after mount_to() had already been called, the route was inserted into self.routes but not into the already-created Starlette sub-application, causing 404 errors. Changes: - BaseAdmin.__init__: add self._mounted_app = None - BaseAdmin.mount_to: save reference to created admin_app - BaseAdmin.setup_view: if mounted, also add route to mounted app's router
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When CustomView was added via
add_view()aftermount_to()had already been called, the route was inserted intoself.routesbut not into the already-created Starlette sub-application, causing 404 errors.ModelViews were not affected because their routes are registered during
init_routes()beforemount_to()is called.Changes
starlette_admin/base.py:102— Addedself._mounted_app = Nonein__init__starlette_admin/base.py:573— Save reference to createdadmin_appinmount_to()starlette_admin/base.py:274-283— Insetup_view(), if mounted, also add route to mounted app's router viaadd_route()tests/test_views.py— Addedtest_custom_view_after_mounttestTesting
test_custom_view_after_mountpasses