Issue 111: change all examples to eliminate deprecated class.#112
Issue 111: change all examples to eliminate deprecated class.#112jplflyer wants to merge 2 commits intojpbarrette:masterfrom
Conversation
…ew inconsistent indentation issues while at it.
|
Hi @jplflyer , your fix is accorded to the Cleanup class documentation, so I'm OK with it. Thanks for your contribution |
|
I entirely removed the code I commented out. I'd left it in there for historical purposes, but it's gone, with the associated comments. It looks like my IDE automatically removes trailing whitespace in C++ code. I didn't know it was doing that. That is probably the explanation for many of the extra changes. I don't have time to spend another 2 hours on this right now. Deadlines at work and deadlines at night. Perhaps you're happy with this the way it is. Perhaps you will leave this dangling, and if I ever get time, I can figure out how to leave your trailing whitespaces alone, but that won't be this week. |
sgallou
left a comment
There was a problem hiding this comment.
Thanks for the removing of comments. But I prefer to wait you remove all remaining spaces differences, because it can create some merge conflicts when merging with other contributors work.
Thanks for your understanding.
|
|
||
| curlpp::terminate(); | ||
|
|
||
| return EXIT_FAILURE; |
There was a problem hiding this comment.
Don't you want to return retVal here ?
Use of the curlpp::Cleanup class is commented as deprecated in the include file, but it's being used in all the examples. This commit changes all of them to use
In a few places, I also fixed inconsistent indentation within the file, but I didn't try to fix different indentation styles across all the examples.