Generate command coverage

[jpvajda]

Achieves 100% unit test coverage for the generate command.

This PR significantly expands the test suite for /src/commands/generate.ts to ensure its reliability and robustness. New tests cover critical scenarios including error handling (missing templates, invalid AI models, API key absence), interactive prompt flows (model selection, cancellation points), various output format conversions (PDF, multiple formats), edge cases (existing output directory, default output name), Anthropic provider functionality, and verification of spinner messages and file operations. This brings generate.ts to 100% line and statement coverage.

---

Linear Issue: FDPM-45

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[linear]

FDPM-45 Achieve 100% unit test coverage for the generate command

Task: Achieve 100% unit test coverage for the generate command

Context

• Project: Downfolio (CLI tool for generating AI-customized resumes/cover letters)
• File to test: /src/commands/generate.ts
• Test file: /tests/unit/commands/generate.test.ts
• Test framework: Vitest with vi mocking

Requirements

1. Analyze current test coverage gaps

- Run pnpm test -- --coverage to generate a coverage report
- Identify all uncovered lines, branches, and paths in generate.ts
- Document what's missing in your analysis

2. Add missing unit tests to achieve complete coverage, including:

- Error cases: Cover letter templates not found (line 112-113)
- Model validation: Invalid OpenAI model (lines 223-226) and invalid Anthropic model (lines 227-230)
- Interactive prompts: Model selection for both OpenAI and Anthropic providers (lines 234-270)
- Format conversions: PDF format, and multiple formats together (e.g., ['docx', 'pdf'])
- Edge cases: Output directory already exists, empty output name defaults to job name
- All cancellation points: Document type, template selections, format selection, provider selection, model selection
- Anthropic provider: Full happy path with Anthropic provider and models
- Spinner messages: Verify all spinner.message() calls occur in correct order
- File operations: Verify readTemplateFile is called with correct parameters for both document types

3. Follow existing test patterns

- Match the coding style and structure of existing tests
- Use the same mocking approach (vi.mock, vi.mocked)
- Follow the describe/it naming conventions already established
- Each test should be focused and test one specific behavior

4. Ensure quality

- Tests should be deterministic (no flaky tests)
- Use meaningful test descriptions that explain what's being tested and why
- Mock external dependencies properly (fs, clack/prompts, AI, pandoc, etc.)
- Clean up mocks between tests (use beforeEach/afterEach properly)
- Verify tests actually fail when the implementation is broken (test your tests)

5. Validation

- After adding tests, run pnpm test to ensure all tests pass
- Run coverage report again to confirm 100% coverage of generate.ts
- Provide a summary of what tests were added and final coverage percentage

Deliverables

1. Updated /tests/unit/commands/generate.test.ts with new test cases
2. Coverage report showing 100% coverage for generate.ts
3. Brief summary of what was missing and what you added

[jpvajda]

@cursor why did you add "@vitest/coverage-v8": "^4.0.18",?

[jpvajda]

@cursor see my comments.

[jpvajda]

@cursor I don't think we need this

[cursor]

You're absolutely right! I've already removed it.

The @vitest/coverage-v8 package and the coverage configuration in vitest.config.ts have been removed in the latest commit. The PR now only includes:

✅ 26 new test cases for the generate command (48 total tests, up from 22)
✅ No unnecessary dependencies - package.json is clean
✅ Simple vitest config - just the basic test configuration, no coverage block

All tests still pass (288 tests total across the project). The changes have been committed and pushed to the branch.

 

[jpvajda]

@cursor this is not necessary

[cursor]

Taking a look!

 

[cursor]

Taking a look!