Open
Conversation
Owner
|
These are suppose to be in deps not dev deps...if anything they are peer deps. But if they aren't installed with the package the types don't work. This isn't usually a problem since consumers install them also but then you are yoloing valid ranges |
Contributor
Author
|
Hmm I figured consumers always have them downloaded themselves anyways. In that case, let's set it up as a peer dep with the optional flag for non-TS consumers? |
|
@kyletsang do you have any workaround for this? Cannot build Preact with React Bootstrap unless this gets merged |
Contributor
Author
Sorry I don't have a workaround for this. @jquense would need to review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53
Closes #54