jquery: Update Twitter to x ,add mastodon and replace FontAwesome font with SVG icons#489
jquery: Update Twitter to x ,add mastodon and replace FontAwesome font with SVG icons#489HermitShamiko wants to merge 15 commits intojquery:mainfrom
Conversation
|
Thank you! I noticed in your footer screenshot that the chat icon seems to be cut off a bit at the top. I wonder if the SVG is not actually square. Could you look into that? |
Fixed the issue where content was affected by line-height.
|
Two new changes:
|
mgol
left a comment
There was a problem hiding this comment.
Thanks for the PR. These are a lot of changes, so I'd like to spend some time testing them on various websites.
See one comment I added.
themes/jquery/css/base.css
Outdated
| .icon-star-empty:before { content: ""; background: url(../lib/FontAwesome/star.svg) no-repeat; } /* Used: learn */ | ||
| .icon-tasks:before { content: ""; background: url(../lib/FontAwesome/bars-progress.svg) no-repeat; } /* Used: learn */ | ||
| .icon-th-large:before { content: ""; background: url(../lib/FontAwesome/table-cells-large.svg) no-repeat; } /* Used: learn */ | ||
| .icon-twitter:before { content: ""; background: url(../lib/FontAwesome/x-twitter.svg) no-repeat; } /* Used: footer */ |
There was a problem hiding this comment.
Could you also add a duplicate .icon-x class and mark this one as deprecated?
There was a problem hiding this comment.
Okay, I've added the icon-x attribute and declared the old icon-twitter as Deprecated, while also switching it to the old Font Awesome to prevent other pages from referencing this icon, since we haven't removed the old version of the Font Awesome file.









@timmywil @mgol
The updated icon style is as follows:

footer(new):
footer(old):

learn(new):

learn(old):
