Skip to content

Fix incorrect handling of the ROOT setting in configuration - #187

Open
nicoyou wants to merge 1 commit into
jrief:masterfrom
nicoyou:bugfix-root
Open

Fix incorrect handling of the ROOT setting in configuration#187
nicoyou wants to merge 1 commit into
jrief:masterfrom
nicoyou:bugfix-root

Conversation

@nicoyou

@nicoyou nicoyou commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

This pull request fixes an issue where the ROOT setting was not being properly read from the configuration.
Due to this, the behavior relying on ROOT did not function as expected in some environments.

Changes made:
Ensured that the ROOT setting is retrieved correctly using getattr with a proper fallback.

Please let me know if any additional changes are needed. Thank you for maintaining this project.

@jrief

jrief commented Jun 17, 2025

Copy link
Copy Markdown
Owner

Which issue does this solve?
Can I reproduce the problems in that issue?

@nicoyou

nicoyou commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

@jrief
For example, when SASS_PROCESSOR_ENABLED is set to true in django 5.0 (4.2>=),
STORAGES['sass_processor'] = {
'BACKEND': 'django.core.files.storage.FileSystemStorage',
'ROOT': 'static path'
}
Even if you register a setting like this, ROOT will be ignored and the compiled css will be generated directly under the project or in the ROOT of FileSystemStorage.
This update will fix this issue.

@nicoyou

nicoyou commented Jun 20, 2025

Copy link
Copy Markdown
Contributor Author

@jrief
I don't have permission to merge into the master branch, so if you accept this pull request, please merge it.

@jrief

jrief commented Jun 21, 2025

Copy link
Copy Markdown
Owner

Again: There is no issue with a description on how to rereduce this bus.

@nicoyou

nicoyou commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

@jrief
I was mistaken, the issue in question is here.
But I couldn't link it.
#181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants