Skip to content

feat: support react@19#270

Open
dimaaan wants to merge 1 commit into
jsardev:masterfrom
dimaaan:master
Open

feat: support react@19#270
dimaaan wants to merge 1 commit into
jsardev:masterfrom
dimaaan:master

Conversation

@dimaaan

@dimaaan dimaaan commented Jan 26, 2026

Copy link
Copy Markdown

Closes #268
Continues #269

@jsardev

jsardev commented Jan 26, 2026

Copy link
Copy Markdown
Owner

Hey @dimaaan, thank you for your contribution! Will take a look at the PR somewhere this week. I know it's small, but I didn't touch the project for a while already and need to catch up how this thing worked 😅

@jsardev jsardev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsardev

jsardev commented Jan 27, 2026

Copy link
Copy Markdown
Owner

@dimaaan Please rebase the PR with the current master - I had to fix CI to work again

@dimaaan

dimaaan commented Jan 27, 2026

Copy link
Copy Markdown
Author

@jsardev done

@jsardev jsardev changed the title support React 19 feat: support react@19 Jan 27, 2026
@jsardev

jsardev commented Jan 27, 2026

Copy link
Copy Markdown
Owner

@dimaaan Thank you! Unfortunately the tests do not pass due to old deprecated stack. I will need some time to update things to Vitest + RTL. Will let you know when it's ready so we could update the PR and make the tests pass.

@jsardev jsardev mentioned this pull request Jan 28, 2026
@jsardev

jsardev commented Jan 28, 2026

Copy link
Copy Markdown
Owner

@dimaaan Can you please merge master in, resolve some of the conflicts and create a changeset for this PR? 🙏

@jsardev

jsardev commented Jan 29, 2026

Copy link
Copy Markdown
Owner

@dimaaan Let me know if you have time to handle this. If not, I'll try to do this, just need info from you 😃

@dimaaan

dimaaan commented Feb 4, 2026

Copy link
Copy Markdown
Author

@jsardev You may handle it yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reaptcha does not support react 19

2 participants