Skip to content

Implement the remaining TODO fixes#96

Merged
jscarle merged 1 commit intodevelopfrom
feature/share-api-fixes
Mar 8, 2026
Merged

Implement the remaining TODO fixes#96
jscarle merged 1 commit intodevelopfrom
feature/share-api-fixes

Conversation

@jscarle
Copy link
Owner

@jscarle jscarle commented Mar 8, 2026

Summary

  • replace the item sharing API with a breaking ShareItem(...) -> ItemShareResult design that supports unrestricted links
  • trim the CLI version output, document item hydration clearly, and add a release draft for the next x.x.x release
  • add regression coverage for archive behavior, share command construction, version trimming, and adding a new field to an existing item

Breaking changes

  • ShareItem(...) now returns ItemShareResult instead of void
  • the single-email overloads were removed; pass a collection for restricted links or omit recipients for unrestricted links

Testing

  • dotnet test OnePassword.NET.Tests\\OnePassword.NET.Tests.csproj -m:1

Closes #90
Closes #91
Closes #93
Closes #94

@jscarle jscarle merged commit 64a31ad into develop Mar 8, 2026
3 checks passed
@jscarle jscarle deleted the feature/share-api-fixes branch March 8, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShareItem requires email trailing /n for version on windows Unable to retrieve Fields using Service Account Token ShareItem has no return value

1 participant