feat(cxf): replace the export panic with a typed ExportUnsupported rejection#174
Merged
Conversation
…jection (#141) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rung 4 of 7 of the interchange-trio ladder (owner-ratified 2026-07-21) — the #141 export floor. #141 stays open; R7 closes it.
What
oce_cxf::exportno longer panics: theunimplemented!()is replaced by the prior-adjudicated typed floor —Err(CxfError::Validation(...))carrying exactly oneDiagnostic::error(DiagCode::ExportUnsupported, ...)with subjectNone(honest for a whole-operation deferral) and the ratified messageCXF export is not yet implemented; every model is rejected until the exporter lands.— the staged rejection surface R5–R7 reuse.DiagCode::ExportUnsupportedadded (additive under#[non_exhaustive]) with its"export-unsupported"arm in the wildcard-freeas_strmatch.export's rustdoc now documents the staged contract (theResultshape is the permanent API); the crate docs no longer claim export panics. Signature unchanged.Tests
3 new export-floor tests (import-then-export, repeated-call stability on the full Diagnostic, hand-built-graph input-independence) + the oce-diag
as_struniqueness/kebab pin extended. Workspace 1219 → 1222. Mutation self-checks: substituted DiagCode → 2 tests fail;Ok(Vec::new())→ all 3 fail.Gates
Implementer + independent lead re-run, both green incl. both rustdoc gates: fmt · clippy · nextest 1222/1222 · doctests · file-size · doc gates · determinism mirror 448/448.
Flagged for backlog, not this PR: the pre-existing oce-diag
as_strpin test omits seven older variants (backfill candidate);oce-docs::point_list_htmlcarries its own deferredunimplemented!(M4 scope).🤖 Generated with Claude Code