feat(cxf): export connector §7.4.1 attributes under the bare-scalar canonical subset (#141)#176
Merged
Conversation
…anonical subset (#141) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rung 6 — connector §7.4.1 attributes: Bare-Scalar Canonical export
Interchange trio rung 6 of 7. Widens the R5 attr-free CXF export subset to emit connector §7.4.1 attributes under one canonical Bare-Scalar Canonical (BSC) wire shape, at the RT-2 render fixpoint.
What
Some):S231:unit/quantity/displayUnitas bare strings (TermAttr::Bare) — Real only;S231:min/maxas bare numbers (CxfValue::Floatfor Real,CxfValue::Intfor Integer) — Real + Integer. Carried on port nodes. All-default connector emits zero attr keys → byte-identical to R5.ExportUnsupported, subject = owning block):nominal(R6-A),unbounded(R6-B), non-finite Realmin/max(R6-C). The importer hardcodesnominal/unboundedtoNone;serde_jsonserializes non-finitef64asnull, which would silently breakrender(G1)==render(G2). The R6-Cfinite_real_boundguard is required for RT-2 (real_connector_boundstoresSome(r)with nois_finitecheck →Some(NaN)is import-reachable), not defense-in-depth.external_inputs, root-URN pre-seed collision.src/resolve/andsrc/dto.rsuntouched.How
classify_attrsreplacesattrs_are_empty; safe totalmatch attrs(noas_real().unwrap()); runs only in theattrs.matches(value_type)branch.build()stays infallible (emit_port_attrs, total match, no unwrap).MSG_ATTRSretired; the headline rejection test converted to the attr-bearing RT-2 acceptance test.Verification (lead, first-hand)
fmt · clippy · 1258/1258 nextest · doctests · both rustdoc doc gates · file-size · 448/448 determinism matrix · machete · no-secret · default-no-db — all green. Importer untouched. Golden
connector_attrs.export.cxf.jsonis the BSC shape (baremin:0.0/max:350.0/unit:"K"/quantity:"ThermodynamicTemperature"/displayUnit:"degC").Merge-review
3-lens Opus review: 3× MERGE, zero blocking findings (RT-2, subset/rejection, build-infallibility+determinism).
Closes no issue yet — R7 closes #141 (arrays flattened-form + enum deferral + enum-free G36).
🤖 Generated with Claude Code