chore: fix astudio-make-template icon package ref#99
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2ba047809
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/ui/src/integrations/apps-sdk-wrapper/index.tsx">
<violation number="1" location="packages/ui/src/integrations/apps-sdk-wrapper/index.tsx:24">
P2: All indentation in this file was changed from 2-space to tabs, violating the project's formatting standard. Both `biome.json` (`indentStyle: "space"`, `indentWidth: 2`) and `.editorconfig` (`indent_style = space`, `indent_size = 2`) mandate 2-space indentation for `.tsx` files. This will likely fail CI formatting checks. Please reformat using spaces.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
6 issues found across 10 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="CLAUDE.md">
<violation number="1" location="CLAUDE.md:17">
P2: Hardcoded absolute local filesystem path (`/Users/jamiecraik/dev/...`) will not resolve for other developers or CI environments. Use a repo-relative path instead.</violation>
</file>
<file name="docs/agents/04-doc-update-gate.md">
<violation number="1" location="docs/agents/04-doc-update-gate.md:3">
P2: Hardcoded absolute local path (`/Users/jamiecraik/...`) in committed documentation. Use a repo-relative path so the reference is portable across machines and CI.</violation>
</file>
<file name="docs/agents/06-security-and-governance.md">
<violation number="1" location="docs/agents/06-security-and-governance.md:5">
P2: Hardcoded absolute path to a local developer's filesystem. This will not resolve for other contributors or in CI. Use a repo-relative path instead.</violation>
<violation number="2" location="docs/agents/06-security-and-governance.md:14">
P2: Hardcoded absolute path to a local developer's filesystem. This will not resolve for other contributors or in CI. Use a repo-relative path instead.</violation>
</file>
<file name="docs/agents/README.md">
<violation number="1" location="docs/agents/README.md:4">
P2: All links use hardcoded absolute local filesystem paths (`/Users/jamiecraik/dev/…`). These resolve only on one developer's machine and will be broken for all other contributors, CI, and GitHub/GitLab rendered views. Use relative paths instead.</violation>
</file>
<file name="AGENTS.md">
<violation number="1" location="AGENTS.md:13">
P1: This file is riddled with hardcoded absolute paths (`/Users/jamiecraik/...`) that are specific to one developer's machine. These will not resolve for other contributors or in CI environments.
- In-repo paths (e.g., to `FORJAMIE.md`, `docs/agents/`, `package.json`) should use **relative paths** from the repo root.
- User-home paths (e.g., `~/.codex/instructions/...`) should use `~` or be documented as user-specific config that each developer sets up locally.
At minimum, replace all `/Users/jamiecraik/dev/design-system/` prefixes with `./` (relative to repo root).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
There was a problem hiding this comment.
7 issues found across 2749 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="CLAUDE.md">
<violation number="1" location="CLAUDE.md:17">
P2: Hardcoded absolute path `/Users/jamiecraik/dev/design-system/AGENTS.md` is machine-specific and won't resolve for other contributors or in CI. Use a repo-relative path instead.</violation>
</file>
<file name="scripts/test-token-drift.mjs">
<violation number="1" location="scripts/test-token-drift.mjs:357">
P3: The `allowedColorDrifts` and `allowedRadiusDrift` warning blocks are duplicated verbatim in the error path and the success path. Extract a shared helper to avoid future drift between the two copies.</violation>
</file>
<file name="docs/agents/README.md">
<violation number="1" location="docs/agents/README.md:4">
P1: All links use hardcoded absolute local filesystem paths (`/Users/jamiecraik/dev/design-system/...`). These won't resolve for other developers, on CI, or on GitHub. Use relative paths instead — all targets are in the same directory.</violation>
</file>
<file name="AGENTS.md">
<violation number="1" location="AGENTS.md:13">
P1: Hardcoded absolute paths (`/Users/jamiecraik/...`) throughout this file will break for every other contributor and in CI. Use repo-relative paths for in-repo files (e.g., `./FORJAMIE.md`, `./package.json`) and `~/.codex/...` for user-home references.</violation>
</file>
<file name="docs/agents/06-security-and-governance.md">
<violation number="1" location="docs/agents/06-security-and-governance.md:5">
P2: Hardcoded absolute local path leaks a developer's home directory and is non-portable for other contributors. Use a repo-relative path instead.</violation>
<violation number="2" location="docs/agents/06-security-and-governance.md:14">
P2: Same absolute-path issue — use a repo-relative link so the reference works for all contributors and on CI.</violation>
</file>
<file name="docs/design-system/COVERAGE_MATRIX.md">
<violation number="1" location="docs/design-system/COVERAGE_MATRIX.md:62">
P2: The newly added lowercase entries duplicate 16 existing PascalCase entries (e.g., `Accordion`/`accordion`, `Dialog`/`dialog`, `Tooltip`/`tooltip`, etc.) with conflicting `Source` classifications (`radix_fallback` vs `local_primitive`). This makes the coverage matrix ambiguous — consumers cannot tell which entry is authoritative or what the actual component source is. Since this file is generated by `scripts/generate-coverage-matrix.ts`, the generator likely needs to be fixed to either deduplicate or correctly merge these entries.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
jscraik
force-pushed
the
codex/fix-design-system-lockfile
branch
from
3dffb32 to
b0e5eb4
Compare
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/design-system/COVERAGE_MATRIX.md">
<violation number="1" location="docs/design-system/COVERAGE_MATRIX.md:62">
P2: The newly added lowercase rows (e.g. `accordion`, `badge`, `button`, `checkbox`, `dialog`, `tooltip`, etc.) duplicate existing PascalCase rows (e.g. `Accordion`, `Badge`, `Button`) but report a different source (`local_primitive` vs `radix_fallback`). This makes the coverage matrix self-contradictory — a reader cannot tell which source is authoritative. The generation script likely needs to deduplicate or merge these entries rather than listing both.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/design-system/COVERAGE_MATRIX.json">
<violation number="1" location="docs/design-system/COVERAGE_MATRIX.json:764">
P2: Bug: `"status": "widget_used"` is not a valid status value — likely a generator script error. The `status` field represents a component lifecycle state (e.g., `"active"`, `"deprecated"`), not a platform-usage flag. Every other component in the matrix has `"status": "active"`. The widget usage is already correctly captured by the `widget_used: true` boolean on the next line. This should remain `"active"`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
Automation triage update: addressed actionable review feedback (guideline import alignment, FORJAMIE update, coverage-matrix path repair, and matrix casing/surface-usage dedupe). Remaining blocker is CI \ failing in \ with broad repo-baseline errors (e.g., TS6307 file-list errors and missing icon/apps-sdk exports) unrelated to this PR scope.\n\nManual next step: land a dedicated baseline typecheck stabilization change on \ (tsconfig/project references + icon/apps-sdk export consistency), then rebase/rerun this PR. |
|
Blocker note: build (ubuntu-latest) fails at Type-check packages with broad baseline errors (TS6307 project file-list, missing icon exports, missing integrations/apps-sdk types). These are repo-wide and not isolated to this PR. Next step: land a dedicated baseline typecheck stabilization PR on main, then rebase and rerun PR #99. |
jscraik
force-pushed
the
codex/fix-design-system-lockfile
branch
from
c05fa7f to
c521acd
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
1 participant
This PR fixes a workspace package-name mismatch and regenerates the pnpm lockfile to repair broken dependency resolution causing CI failures (missing esbuild@0.27.3).
Summary by cubic
Switched astudio-make-template to use @design-studio/astudio-icons and aligned docs/examples so template consumers import the correct package. Removed a malformed Apps SDK wrapper, hardened the coverage matrix generator, and refreshed the lockfile to keep CI and docs consistent.
Written for commit c521acd. Summary will update on new commits.