Create Devtools package and its Roblox plugin#14
Draft
jeparlefrancais wants to merge 6 commits intojsdotlua:mainfrom
Draft
Create Devtools package and its Roblox plugin#14jeparlefrancais wants to merge 6 commits intojsdotlua:mainfrom
jeparlefrancais wants to merge 6 commits intojsdotlua:mainfrom
Conversation
matthargett
reviewed
Sep 18, 2023
Collaborator
matthargett
left a comment
There was a problem hiding this comment.
Minor comments. Great work!
packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.luau
Show resolved
Hide resolved
Kampfkarren
reviewed
Sep 22, 2023
| return | ||
| end | ||
|
|
||
| if runModes.edit then |
There was a problem hiding this comment.
Not good, I essentially make my entire game in Hoarcekat--I need it there!
Collaborator
Author
There was a problem hiding this comment.
Yep! For now I want to disable it to prevent any confusion about the plugin not working in edit mode.
It's definitely possible to make it work though, the plugin would just need to make sure to re-connect and clean up the connections correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up a Roblox plugin that re-implements the React developer extension
We cannot use the existing extensions (like the chrome or firefox extensions) because Roblox does not have a socket API, so it cannot communicate with them. That is why I built this plugin.
The goal was to get the profiler working, so the "components" tab is not implemented.
Notes
How to test it out
You will need the plugin and a few modification in your code before you render your root.
Build the plugin
Roblox setup
Here is an example of how to setup the devtools inside Roblox:
Screenshot of the extension