Add keyboard shortcut hints to empty pane placeholder#123
Open
jsgrrchg wants to merge 3 commits into
Open
Conversation
The empty pane placeholder now lists each action alongside its keyboard shortcut, resolved from the shortcut registry at render time so hints stay accurate after rebinds and use the correct platform modifier (⌘ vs Ctrl). Closes #119
Owner
Author
|
Needs PR 118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the empty-pane placeholder to list each action alongside its keyboard shortcut, as requested in #119.
Before:
After:
Details
ShortcutHintcomponent renders a<kbd>-styled badge using the existing design tokens.formatShortcutAction(action, getDesktopPlatform()), so the hints stay accurate after rebinds and the platform modifier (⌘vsCtrl) resolves correctly per OS.quick_switcher(⌘O / Ctrl+O)command_palette(⌘K / Ctrl+Shift+P)new_agent(⌘⇧N / Ctrl+Shift+N)new_terminal(⌘R / Ctrl+R) — matches the owner's clarification in the issue thread (Cmd+R/Ctrl+R).Testing
vitest runforWorkspacePaneEmptyState.test.tsx— passing (asserts action phrases + resolved<kbd>labels)tsc -b— cleaneslinton touched files — cleanCloses #119