Clear file tree selection on pane click#124
Open
jsgrrchg wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clears explicit multi-selection in the file tree when the user clicks back into an editor/workspace pane.
Why
Multi-selected files and folders stayed visually selected after focus moved back to the editor, which made the tree feel like it had stale contextual state. The tree should keep multi-selection while the user is operating inside it, but clear that contextual selection when another main pane becomes active.
Changes
clearFileTreeSelectionUI event in the navigation utilities.FileTreeby having it listen for the cleanup event.Validation
npm test -- --run src/features/vault/FileTree.test.tsx src/features/editor/MultiPaneWorkspace.test.tsxnpx tsc -b --pretty false