fix: add tigervnc dependency and update DinD for compatibility#199
fix: add tigervnc dependency and update DinD for compatibility#199rimorgin wants to merge 1 commit into
Conversation
|
Thank you for looking in to this. Please allow me some time to review, as I am currently on holiday. |
|
Thanks for the fix. To make sure everybody can trace where the modified busybox came from, can you change the dockerfile to download it during build process, instead of adding it to git? Other then that, thank you very much for looking into this. I would not have found this myself for sure! |
|
Actually, maybe it would be even better to copy the binary directly from the busybox docker container using a multistage build; that way this container is automatically rebuild whenever the upstream container gets a new version. Is this something that you can investigate @rimorgin? |
|
i'm excited on this :) |
|
using multi-stage build is definitely the appropriate fix for this one, glad you point that out. I'll investigate it and give me some time. |
e3dcf91 to
a605159
Compare
An issue encountered when launching the webterm container in GNS3, where VNC support fails due to a missing TigerVNC server.
The log containing the error message:
the solution to this issue it either:
fix no.1
docker exec -it gns3 sh -c 'apk update && apk add tigervnc'fix no.2 the permanent solution which is adding tigervnc to the dependencies.json. As of this writing, the tigerVNC version i included on the dependencies.json is
1.13.1-r5The second issue addressed here #198 is when starting docker containers with incompatible busybox symlinking.
this command
ln -s /bin/busybox /usr/lib/python*/site-packages/gns3server/compute/docker/resources/binsymlinks to the resources that docker containers used (webterm, ipterm, etc.) which are incompatible because the busybox is alpine compatible onlythe workaround to this issue is to use different busybox and can be downloaded here https://syndamia.com/tutorials/gns3-initsh-no-such-file/
i did test the busybox downloaded from the url and the container starts magically with no error.
So i added a permanent solution in the Dockerfile with this lines: