Skip to content

Codex-generated pull request#5

Open
jsinatro wants to merge 1 commit intomainfrom
codex/reorganize-portfolio-content-for-professionalism-n00f49
Open

Codex-generated pull request#5
jsinatro wants to merge 1 commit intomainfrom
codex/reorganize-portfolio-content-for-professionalism-n00f49

Conversation

@jsinatro
Copy link
Owner

Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.


Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b98d5b6f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


async function openPathWithFallback(path, successMessage, fallbackMessage) {
try {
const response = await fetch(path, { method: 'HEAD' });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve user activation before opening CV tab

The cv/curriculo flow now awaits fetch(..., { method: 'HEAD' }) before calling window.open, so the popup is no longer tied to the original keypress/click activation. In browsers with popup blocking enabled, this causes the new tab to be blocked even when the target file exists, so users get a success message but no document opens. Open the tab synchronously (or pre-open and then navigate it) to keep this command reliable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant