Draft
Conversation
jsitaraman
reviewed
Sep 27, 2021
| qnn=gpu::allocate_on_device<double>(sizeof(double)*(ncells+nhalo)*nfields); | ||
| res_d=gpu::allocate_on_device<double>(sizeof(double)*(ncells+nhalo)*nfields); | ||
| dq_d=gpu::allocate_on_device<double>(sizeof(double)*(ncells+nhalo)*nfields); | ||
| res_d=gpu::allocate_host_pinned<double>(sizeof(double)*(ncells+nhalo)*nfields); |
Owner
There was a problem hiding this comment.
Why allocate res_d and dq_d as host pinned ? I get that for the qbuf, but won't this be inefficient if we host pin the residual and dq, the main arrays that get filled in by GPU kernels ?
Collaborator
Author
There was a problem hiding this comment.
I believe I made this change b/c both res_d and dq_d are passed to the UpdateFringes. Yes, I agree this is definitely not ideal -- I am still fiddling with it.
Uses host-pinned mapped memory, which alleviates the need for copying the data from host-to-device in UpdateFringes.
gzagaris
force-pushed
the
feature/gzagaris/host-pinned-memory
branch
from
43ef1cd to
b6bba0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.