Add serde-saphyr benchmark event path#64
Merged
Conversation
The event-backed deserializer expands aliases lazily while it walks, so the
parser's literal nesting-depth check did not bound the expanded depth. A
literally shallow document with a long alias chain recursed until the stack
overflowed. Enforce the configured maximum nesting depth during alias
expansion across the value walk, the ignored-node skip, and the key/merge
materialization scan, matching the tree-backed alias handling, which rejects
such documents instead of crashing.
Also deserialize externally-tagged enum variants that carry a payload
(newtype, tuple, and struct variants, plus tag-shorthand variants). The path
previously accepted only bare-scalar unit variants and errored on every
`{Variant: payload}` mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saneyaml::__unstable_event_serdebenchmark surface.Verification
Local proof from this checkout:
cargo fmt --checkgit diff --checkcargo test --lockedcargo clippy --locked --all-targets -- -D warningsscripts/check-feature-clippy.shcargo test --locked --lib event_decargo package --locked --allow-dirtyBenchmark captures are recorded in
docs/BENCHMARKS.md; the event-backed lane is intentionally documented as benchmark-only, not a public API replacement.Notes/Risks