[codex] Fix conversation history restore decoding#33
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review please run a code review on the latest PR head. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex review pass: I did not find a blocking issue in this pass. Caveat: I did not run local tests; this is the narrow ISO-8601 restore fix, but PR checks only show GitGuardian/Vercel-style checks, not an iOS build/test lane. |
|
Closing during open-PR cleanup: superseded by #36, which carries the async restore decoding fix with targeted tests. No code was merged from this branch. |
What changed
ConversationStore's async history index loader to decode ISO-8601 dates before reading persisted metadataConversationSnapshotLoaderto use the same ISO-8601 date decoding when restoring saved conversationsWhy
Persisted conversation files and the history index are written with ISO-8601 timestamps. The async restore path was using a plain
JSONDecoder, so restores could fail after the app had already saved valid history.User impact
Root cause
ConversationStoreencoded dates as ISO-8601 but two async decode paths did not setdateDecodingStrategy = .iso8601. That mismatch broke history restoration and pushed the app into creating replacement empty threads.Validation
Yemma4