Make code 2.7 compatible#5
Conversation
* Move from use of UserDict to subclassing dict directly since UserDict in 2.x is an old-style class which makes multiple inheritance and calling __init__ awkward. * Use six for things moved in 3.x (urllib.error) * require mock since mock isn't present at all in 2.x
|
@mike-hart Hey there. Firstly, sincere apologies that I missed this PR. I will take a look at these changes and get them incorporated when I get a chance. Secondly, I no longer have any use for this lib, and so will not be able to prioritize it very well. I don't plan on developing for this in the future so feel free to make it your own if necessary. |
|
Hi there, no worries, it's a little imperfect anyway (I ended up using magicsuper to fix the area I missed rather than trying to make it directly compatible with both for now). You may have seen I've made a fair number of other fixes that I haven't submitted a PR for. I understand if you're no longer using it and there's no pressure to apply, I just figured I'd offer since I'd: Are you using a platform other than Interact/Responsys now, or are you using a different library/language for interaction (if the latter I'd also be interested)? |
2 participants
2.x is an old-style class which makes multiple inheritance and calling
init awkward.