Throw an exception when trying an unsupported TLD#34
Open
tomsommer wants to merge 1 commit intojsmitty12:masterfrom
Open
Throw an exception when trying an unsupported TLD#34tomsommer wants to merge 1 commit intojsmitty12:masterfrom
tomsommer wants to merge 1 commit intojsmitty12:masterfrom
Conversation
tomsommer
changed the title
Owner
|
While I don't have a problem with this change (I quite like it, in fact), it is a backwards compatibility break and minimally needs to be documented with @throws. I think it also wise to start a running list of changes in the I would also like to see a test case verifying that the correct exception is thrown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw an exception when trying an unsupported TLD, instead of returning empty data.