Open
Conversation
|
Hi @Adityakk9031! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description, completed checklist items Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
Author
|
@Utkarsh-123github sir please check this pr |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 663 663
Branches 205 205
=========================================
Hits 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jagpreetrahi sir have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix – corrects string detection in the custom JSON parser to properly handle escaped backslashes and quotes.
Issue Number
Closes #2237
Screenshots / Videos
N/A – this is a logic fix in the parser. Automated tests have been added to verify the behavior.
Summary
This PR fixes a bug in the custom JSON parser (
lib/getPartsOfJson.ts) where strings ending with an escaped backslash (for example,"value \\\\") were incorrectly treated as unterminated. This caused syntax highlighting and parsing issues for the remainder of the JSON block. The fix updates the string‑matching and quote‑detection logic so that escaped characters are handled correctly and valid JSON strings are no longer misclassified.Changes
regexStringto correctly match strings containing escaped characters as produced byJSON.stringify.regexDoubleQuoteto use a parity‑aware lookbehind so that only truly unescaped quotes are treated as string terminators.getFindResultsByGlobalRegExphelper.Does this PR introduce a breaking change?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.